Visual Studio Code F2 rename symbol key is adding newlines in Python

[HezzyBear]

Issue Type: Bug

Select a word. Hit F2 key. Change word. After I hit enter there are now spaces between the lines.

VS Code version: Code 1.58.2 (c3f126316369cd610563c75b1b1725e0679adfb3, 2021-07-14T22:10:15.214Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

[alexdima]

@HezzyBear I cannot reproduce. Do you have additional details to help us reproduce?

Kapture.2021-08-17.at.15.43.25.mp4

[HezzyBear]

Like I said, when I go to rename something for some reason it adds double spacing. I have no additional details. Thanks for responding back to me. I really appreciate it!

…

On Tue, Aug 17, 2021 at 9:43 AM Alexandru Dima ***@***.***> wrote: @HezzyBear <https://github.com/HezzyBear> I cannot reproduce. Do you have additional details to help us reproduce? https://user-images.githubusercontent.com/5047891/129736679-12b6f1b4-d023-41af-816e-fe74891949d7.mp4 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/microsoft/vscode/issues/128868#issuecomment-900310825>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU35NJL23WYZOON3BBBTXZTT5JRRZANCNFSM5AQDWCBQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[alexdima]

@HezzyBear Could you perhaps try to create a screen recording. Did you see the one I created, are you doing anything different? Does this reproduce when disabling all extensions?

[HezzyBear]

connect4.py.-.Visual.Studio.Code.2021-08-23.13-35-34.mp4

[HezzyBear]

@alexdima As you can see I've posted a video. The only extension I have running is the IntelliSense (Pylance), Linting, Debugging (multi-threaded, remote), Jupyter Notebooks, code formatting, refactoring, unit tests, and more. If you need anymore info don't hesitate to ask. Thanks Gary

[alexdima]

@HezzyBear Thank you for the extra information. This looks like a problem with the Python language server that computes the edits for renaming. It appears it is inserting \n after all lines.

We might want to move this to https://github.com/microsoft/vscode-python

[karthiknadig]

This is pappasam/jedi-language-server#159

[brettcannon]

This also means that you are not using Pylance, @HezzyBear . If you explicitly want Pylance then please check your "python.languageServer" setting.

[aravindmdev]

Installing Pylance will resolve this issue.

[luabud]

Closing in favour of upstream issue pappasam/jedi-language-server#159.