Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify linting with PTVS analysis active #1004

Closed
MikhailArkhipov opened this issue Mar 9, 2018 · 2 comments · Fixed by #1231
Closed

Verify linting with PTVS analysis active #1004

MikhailArkhipov opened this issue Mar 9, 2018 · 2 comments · Fixed by #1231
Assignees
Labels
area-linting feature-request Request for new features or functionality
Milestone

Comments

@MikhailArkhipov
Copy link

MikhailArkhipov commented Mar 9, 2018

PTVS analyzer provides syntax error squiggles. It does not, however, provide extensive linting as, say, pylint. We need to verify linters work as expected with PTVS active.

@MikhailArkhipov MikhailArkhipov added feature-request Request for new features or functionality area-linting needs PR labels Mar 9, 2018
@MikhailArkhipov MikhailArkhipov added this to the March 2018 milestone Mar 9, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Mar 9, 2018
@DonJayamanne
Copy link

Thus we need to run pylint with certain messages suppressed in order to avoid duplicate error reports.

Should we bother. If we are, then we'll need to do this for All linters.

@MikhailArkhipov MikhailArkhipov changed the title Linting with PTVS analysis active Verify linting with PTVS analysis active Mar 10, 2018
@MikhailArkhipov
Copy link
Author

Maybe not. We can just leave code as it is so it lints on save, if enabled. If there are syntax errors, one would get duplicates but so would happen if multiple linters are on. If there are no syntax errors, then only lint messages will appear.

I changed title to 'verify linters work with PTVS active'

@brettcannon brettcannon modified the milestones: March 2018, April 2018 Mar 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants