Support Gitlab

[dqbd]

It would be amazing if this extension would support Gitlab too.

[svipas]

I totally agree with this! It's so powerful extension we definitely need support for GitLab!

[RMacfarlane]

@delold @svipben I'm happy you're excited about this!

To build this extension, we introduced a new proposed api for adding comments that is meant to be generic (in the release notes here: https://code.visualstudio.com/updates/v1_27#_comment-providers). This extension is meant only to add support for GitHub pull requests - trying to make it integrate with other git providers would make it bloated. Instead, we plan to create a separate extension for each git provider.

[svipas]

Omg, thank you very much!🔥

[swiffer]

@RMacfarlane don't know about your planning Progress - Just wanted to point to GitLab Workflow, created by Fatih Acet over at GitLab. Perhaps its worth talking with him.

[fatihacet]

I have created a VSCode extension for GitLab called GitLab Workflow. It supports creating MRs, issues and pipelines directly from VSCode. You can also see pipeline status, MR link and closing issue link on the VSCode status bar. Feel free to take a look at it https://marketplace.visualstudio.com/items?itemName=fatihacet.gitlab-workflow

[sandeepp-cuelogic]

@fatihacet GitLab Workflow is truly awesome for gitlab users! It would be great if we can add review comments within VSCode GitLab Workflow as well, it should definitely help large developer base. Kudos Github Pull Request provider team!!!

[RMacfarlane]

Hi @fatihacet 👋 Awesome extension! The comment provider API is still being stabilized and there are a lot of things I would like to add to it. Would welcome your feedback here: microsoft/vscode#53598

[goloveychuk]

Can't we have a Provider interface layer, with functions like getAllPrs, getCommentsForPr and have support for all git providers?
edit: oh, I see https://github.com/Microsoft/vscode-pull-request-github/blob/master/src/github/interface.ts
Would it be enough to implement those interfaces for bitbucket/gitlab?

[le91688]

Have any other git providers implemented anything using comments yet? Anything in the works?