-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resolving conversations #339
Comments
I would like to add that I don't necessarily want "outdated" comments hidden, but i would like "resolved" comments hidden. I hope that the resolve button is available and that these two properties can be filtered separately. |
Looks like this property is currently exposed by the Github API: https://developer.github.com/v3/issues/comments/ |
This makes life really difficult because when using this to update my code from the code review it doesn't distinguish between completed work (resolved comments) and in progress ones. |
+1 just tried out the extension and can see myself using it regularly if resolving conversations directly from VSCode was possible, otherwise, there's too much noise and I end up going directly to the GitHub website. |
Same as the last two comments -- If in the Github PR UI the |
I would also really like to see this feature. I'm still reviewing PRs through the website instead of VSCode because of it. As @dylmye pointed out, it is exposed by the API. Would anyone have a pointer on what files need to be edited to add this support? I might be willing to work on this, but would need some mentorship. |
The extension is awesome but this features is really blocking me from using that day-to-day |
I agree, this extension would be perfect if it had this feature :). |
Throwing my hat in here too. This extension is unusable to me until I can hide resolved comments/see only unresolved comments. |
+1. It would be great if resolved comments could at least be indicated somehow in the UI, or if the extension could remember the "collapsed" state across closing and re-opening a particular diff. |
+1 for remembering that a comment is resolved. Or at least remember if we've collapsed the comment locally within a review session. |
FYI, I have switched my code reviews to Reviewable.io now. That lets me hide resolved comments and quickly go through all my previous comments, to ensure that all my comments have been addressed. Overall, it has really helped me keep track of reviews for large PRs. I am not affiliated with Reviewable, just a very happy customer. |
cc @RMacfarlane @alexr00 I self-assigned this forever ago but I'm not doing much GHPR anymore. |
Totally agree, it's very noisy and make PR review unusable. |
Link broken |
Needs support for deemphasizing outdated/resolved comments #89
The text was updated successfully, but these errors were encountered: