Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving conversations #339

Closed
Tyriar opened this issue Aug 30, 2018 · 16 comments · Fixed by #2641
Closed

Support resolving conversations #339

Tyriar opened this issue Aug 30, 2018 · 16 comments · Fixed by #2641
Assignees
Labels
feature-request Request for new features or functionality ghcs-scenario-found on-testplan
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 30, 2018

screen shot 2018-08-30 at 9 55 03 am

Needs support for deemphasizing outdated/resolved comments #89

@Tyriar Tyriar added the feature-request Request for new features or functionality label Aug 30, 2018
@aoberoi
Copy link

aoberoi commented Sep 11, 2018

I would like to add that I don't necessarily want "outdated" comments hidden, but i would like "resolved" comments hidden. I hope that the resolve button is available and that these two properties can be filtered separately.

@dylmye
Copy link

dylmye commented Sep 12, 2018

Looks like this property is currently exposed by the Github API: https://developer.github.com/v3/issues/comments/

@adrian-ci
Copy link

This makes life really difficult because when using this to update my code from the code review it doesn't distinguish between completed work (resolved comments) and in progress ones.

@myartsev
Copy link

myartsev commented Apr 4, 2019

+1 just tried out the extension and can see myself using it regularly if resolving conversations directly from VSCode was possible, otherwise, there's too much noise and I end up going directly to the GitHub website.

@stgarf
Copy link

stgarf commented Jun 14, 2019

Same as the last two comments -- If in the Github PR UI the resolved comments and outdated comments are hidden when appropriate (e.g. when resolved and/or outdated) but I also can click a small icon to reveal them to take a second-glance, this would be the icing on the cake for this extension. I basically don't need to leave VSCode... :)

@JaimieMurdock
Copy link

I would also really like to see this feature. I'm still reviewing PRs through the website instead of VSCode because of it. As @dylmye pointed out, it is exposed by the API. Would anyone have a pointer on what files need to be edited to add this support? I might be willing to work on this, but would need some mentorship.

@liang2zhu1
Copy link

The extension is awesome but this features is really blocking me from using that day-to-day

@ghs180
Copy link

ghs180 commented Jan 17, 2020

I agree, this extension would be perfect if it had this feature :).

@judy
Copy link

judy commented Feb 5, 2020

Throwing my hat in here too. This extension is unusable to me until I can hide resolved comments/see only unresolved comments.

@MrMage
Copy link

MrMage commented Feb 18, 2020

+1. It would be great if resolved comments could at least be indicated somehow in the UI, or if the extension could remember the "collapsed" state across closing and re-opening a particular diff.

@hasbro17
Copy link

+1 for remembering that a comment is resolved. Or at least remember if we've collapsed the comment locally within a review session.
Great extension overall except for some rough edges like this which break your focus while reviewing and force you back to the browser to see what comments are outdated.

@MrMage
Copy link

MrMage commented May 25, 2020

FYI, I have switched my code reviews to Reviewable.io now. That lets me hide resolved comments and quickly go through all my previous comments, to ensure that all my comments have been addressed. Overall, it has really helped me keep track of reviews for large PRs.

I am not affiliated with Reviewable, just a very happy customer.

@JacksonKearl JacksonKearl added this to the Backlog milestone Aug 10, 2020
@JacksonKearl JacksonKearl removed their assignment Oct 13, 2020
@JacksonKearl
Copy link
Contributor

cc @RMacfarlane @alexr00 I self-assigned this forever ago but I'm not doing much GHPR anymore.

@Perh0rd
Copy link

Perh0rd commented Dec 17, 2020

Totally agree, it's very noisy and make PR review unusable.

@bamurtaugh
Copy link
Member

@Perh0rd
Copy link

Perh0rd commented Jan 30, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality ghcs-scenario-found on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.