Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Webview UI Toolkit for Visual Studio Code for webview controls #3035

Open
daviddossett opened this issue Oct 13, 2021 · 0 comments
Open

Comments

@daviddossett
Copy link
Contributor

daviddossett commented Oct 13, 2021

Proposal

Hi all! 👋

Now that we've released the Webview UI Toolkit for Visual Studio Code, I think it would great to swap the bespoke/styled UI components in the extension with their counterparts in the toolkit. This would reduce the load on maintainers to have to keep up with visual/theme/accessibility consistency with VS Code itself, among other advantages.

You can view the components in a Storybook environment here.

From what I've seen, the primary webviews in the extension use inputs, buttons (icon, primary, secondary), tags, checkboxes, and links. I believe the toolkit covers all of those components spare the split button currently used for selecting a merge method. That component is in our backlog to be added soon.

References

CleanShot 2021-10-13 at 11 15 40@2x

CleanShot 2021-10-13 at 11 17 08@2x

cc @hawkticehurst @misolori

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants