Use runInTerminalRequest

[roblourens]

No description provided.

[weinand]

@roblourens runInTerminal can easily be used in the implementation of the launchRequest (instead of copying the implementation of external terminals from node-debug).

[roblourens]

I'm not quite sure what you mean?

[weinand]

@roblourens node-debug's 'launchRequest' supports to run the debug target in an external terminal on all platforms (in addition to running it in the debug console). Currently this feature is implemented in node-debug (terminal.ts).

It is not necessary to implement this 'external terminal support' in the same way in chrome-debug. Instead chrome-debug should use the (reverse) 'runInTerminalRequest' to request similar functionality from VS Code. This is the recommended approach for all debug adapters that need to support an external terminal.

'runInTerminalRequest' is not a normal request that the debug adapter implements, but it is a request that the debug adapter uses. So the title of this issue should better be "Use runInTerminalRequest".

[roblourens]

Oh, I see. The adapter sends a runInTerminalRequest and can set kind = 'integrated' or 'external', and VS Code will manage either one. Gotcha.

[weinand]

@roblourens in the August milestone only 'integrated' is implemented.

[roblourens]

Fixed last week