Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_mssql for VSCode_mssql Extension_Connections_ScreenReader: Screen Reader is not reading the full information related to the database name. #17204

Closed
Yashi1201 opened this issue Jan 11, 2022 · 13 comments
Assignees

Comments

@Yashi1201
Copy link

Yashi1201 commented Jan 11, 2022

Actual:

Screen Reader is not reading the full information related to the database name.

Similar issue is also observed in following:-

  1. mssql Extension-Context Menu actions:- Screen Reader is not reading full information about the System View selected. Screen reader is not reading any information about the more items present for selected system view.

Similar issue is observed with Jaws.

Expected:

Screen Reader should read the full information related to the database name. It should also read like press "Shift+F10" to expand the more items.

GitHubTags:#A11yMAS;#A11yTCS;#BM_mssql for VSCode_Jan2022;#mssql for VSCode;#Win32;#FTP;#DesktopApp;#A11ySev2;#AINotInScope;#WCAG1.3.1;#NVDA;#Jaws;#STP;#Element:menuitem;

Environment Details:

Application Name: mssql for VSCode
Windows Version: Win10
Screen Reader: NVDA(2021.3), Jaws(2022.2112.24)

Repro Steps:

  1. Open Visual studio code
  2. Tab till extension button and search for "mssql"
  3. Tab till install and move to the SQL Server button
  4. Tab till Add Connection Button and insert the valid credentials
  5. Once the database is added.
  6. Run NVDA and observe if it reads anything about the more items present.

User Impact:

Screen reader users will not get full information about the more items present for database name.

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

@smartguest
Copy link
Contributor

smartguest commented Jan 21, 2022

A similar issue has been observed with vscode in general where the screen reader won't get further details about more items present in a collapsed dropdown, this is not just limited to the database tab. Additional context menu commands accessed by "Shift-F10" are not announced. Again, this needs to be investigated by the vscode team.

@smartguest
Copy link
Contributor

Closing as this is considered default behavior of vscode folders and the screen reader already announces that there are more items inside (expanded/collapsed), which means a user can go inside and read about more contents inside the folder/database if they so wish.

@Yashi1201
Copy link
Author

@smartguest This bug can be closed by trusted testers by C + AI team after bug verification. Can you please change the bug to open state.
As per your comment, "The screen reader already announces that there are more items inside (expanded/collapsed), which means a user can go inside and read about more contents inside the folder/database if they so wish." The items we see after expansion are not the same when we right click on the parent item. Hence, the key for right click needs to be announced if you state this bug is external to another product, please let us know so that we can take appropriate action.

@Yashi1201
Copy link
Author

Yashi1201 commented Jul 1, 2022

@smartguest Can you please look into the above comment and change the bug to open state. Thanks

@Yashi1201
Copy link
Author

@smartguest Could you pls reopen the bug as the issue is still repro. The screenreader is not announcing any information about the more items menu which opens up when we right click with mouse or on pressing keyboard key "Shift+F10". Hence, the key for right click needs to be announced if you state this bug is external to another product, please let us know so that we can take appropriate action.
17204_issue repro

@Charles-Gagnon Charles-Gagnon reopened this Feb 2, 2023
@alanrenmsft alanrenmsft added this to the March 2023 Release milestone Feb 3, 2023
@smartguest
Copy link
Contributor

smartguest commented Feb 10, 2023

@Yashi1201 This is part of an external issue with VSCODE folders and not with vscode-mssql specifically,

If you right click or press Shift-F10 on a folder in VSCODE containing multiple items, it will also simply state "Menu" without any additional information as well (outside of the MSSQL extension). They will need to add the feature announcing the more items can be accessed by pressing Shift-F10 or right click.

Also in regards to issue of full information of the database name, the vscode team has stated they will not change the current design for folders due to the proposed change causing too much noise:
microsoft/vscode#141316 (comment)

@smartguest
Copy link
Contributor

@alanrenmsft Should we attempt to do anything with this or not? This is a VSCODE dependency issue first and foremost involving the folders. I'm going to file an issue with VSCODE about this.

@alanrenmsft
Copy link
Contributor

@smartguest i will take care of the issues

@alanrenmsft
Copy link
Contributor

@Yashi1201
This is what I have observed:

  1. Select the connection node
  2. Press Shift+F10 or the context menu key, NVDA announces: 'Menu'
  3. Press up/down keys to visit the menu items, NVDA will announce the menu item name, the order as well as the total menu item count.

things are all working as I would expect. please let me know what is not working?

image
image

@alanrenmsft
Copy link
Contributor

@Roopesh-T I suppose this was reactivated as per your team's request, I couldn't find the alias of the person who opened this issue originally. Could you please also take a look at by reply above?

@Yashi1201
Copy link
Author

Yashi1201 commented Feb 14, 2023

@alanrenmsft Here, when focus is on connection node and screen reader reads "level 1 sqltools2019-3,(adstest) expanded 1 of 1" but screen reader does not read any information about the key of right click to open the menu. So, the screen reader users will not get to know that "Shift+f10" needs to be pressed to open the menu.

Hence, the key for right click i.e. "Shift+f10" needs to be announced so that screen reader users will know which key to be pressed to get the menu.

Here, is my alias [email protected]

GithubTags:#Regressed:02-14-23;

@alanrenmsft
Copy link
Contributor

@Yashi1201 Now I understand what you are referring to. But that doesn't seem reasonable to me, it would also be annoying to announce that every time a node is selected. Do you have an example of any application implementing this requirement? I tried on Windows File Explorer, it also doesn't announce the context menu available.

I think anyone who relies on keyboard only interaction should know to use Shift+F10 or the context menu key to open context menus.

@Yashi1201
Copy link
Author

@alanrenmsft We discussed this bug with usability team , they said it is default behaviour and the user know the key for right-click to open context menu.

GithubTags:#Closed;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants