From 8931cf0ecbebcc8900b58c560ef082d0c45aaf26 Mon Sep 17 00:00:00 2001 From: Kevin Cunnane Date: Wed, 1 Mar 2017 14:06:47 -0800 Subject: [PATCH] Fix changelog open broken by VSCode 1.10.0 (#750) - Opening a local file in the HTML Preview pan is broken in 1.10. It looks like this is a bug in VSCode that isn't in the Insiders build - Moving to opening the Master changelog.md in the users default browser instead. This is consistent with our GettingStarted action. --- CHANGELOG.md | 2 +- README.md | 2 +- src/constants/constants.ts | 1 + src/controllers/mainController.ts | 12 +----------- src/views/htmlcontent/src/docs/index.html | 2 +- 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index bf8d4f5cde..4d6b28e49a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Change Log ## Version 0.3.0 -* Release date: February 28, 2016 +* Release date: March 1, 2016 * Release status: Public Preview ## What's new in this version diff --git a/README.md b/README.md index 94fbbb1232..3b98c08fad 100644 --- a/README.md +++ b/README.md @@ -120,7 +120,7 @@ See [customize options] and [manage connection profiles] for more details. ``` ## Change Log -The current version is ```0.2.0```. See the [change log] for a detailed list of changes in each version. +The current version is ```0.3.0```. See the [change log] for a detailed list of changes in each version. ## Supported Operating Systems diff --git a/src/constants/constants.ts b/src/constants/constants.ts index f98f0a8200..6ade5edbe6 100644 --- a/src/constants/constants.ts +++ b/src/constants/constants.ts @@ -47,6 +47,7 @@ export const renamedOpenTimeThreshold = 10.0; export const timeToWaitForLanguageModeChange = 10000.0; export const macOpenSslHelpLink = 'https://github.com/Microsoft/vscode-mssql/wiki/OpenSSL-Configuration'; export const gettingStartedGuideLink = 'https://aka.ms/mssql-getting-started'; +export const changelogLink = 'https://aka.ms/vscode-mssql-changelog'; export const sqlToolsServiceCrashLink = 'https://github.com/Microsoft/vscode-mssql/wiki/SqlToolsService-Known-Issues'; // Configuration Constants diff --git a/src/controllers/mainController.ts b/src/controllers/mainController.ts index ca46dda1a5..36d28b0e05 100644 --- a/src/controllers/mainController.ts +++ b/src/controllers/mainController.ts @@ -372,17 +372,7 @@ export default class MainController implements vscode.Disposable { * Shows the release notes page in the preview browser */ private launchReleaseNotesPage(): void { - // get the URI for the release notes page - let docUri = vscode.Uri.file( - this._context.asAbsolutePath( - 'out/src/views/htmlcontent/dist/docs/index.html')); - - // show the release notes page in the preview window - vscode.commands.executeCommand( - 'vscode.previewHtml', - docUri, - vscode.ViewColumn.One, - 'mssql for VS Code Release Notes'); + opener(Constants.changelogLink); } /** diff --git a/src/views/htmlcontent/src/docs/index.html b/src/views/htmlcontent/src/docs/index.html index 312007cf24..983a905c41 100644 --- a/src/views/htmlcontent/src/docs/index.html +++ b/src/views/htmlcontent/src/docs/index.html @@ -3,7 +3,7 @@

Version 0.3.0

What's new in this version