Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown syntax highlighting doesn't combine bold + italic #69

Open
gmccullo opened this issue Mar 13, 2020 · 6 comments
Open

markdown syntax highlighting doesn't combine bold + italic #69

gmccullo opened this issue Mar 13, 2020 · 6 comments
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@gmccullo
Copy link

Issue Type: Bug

Markdown syntax highlighting will display bold or italics but not both. For example:

image

Running without extensions makes no difference.

VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:47:57.235Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz (4 x 2496)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.93GB (6.54GB free)
Process Argv
Screen Reader no
VM 0%
@vibl
Copy link

vibl commented Nov 3, 2022

It's been 2.5 years since this issue was submitted. The bug is still pressent.

@mjbvz
Copy link
Contributor

mjbvz commented Nov 3, 2022

@vibl The status is: you haven't submitted a pr to fix this in 2.5 years :)

@mjbvz mjbvz added this to the Backlog milestone Dec 5, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2022
@JesseSteele
Copy link

FWIW, the text example in #159 shows many different combinations for testing. We're now over 4 years on this bug. Game on!

@RedCMD
Copy link
Contributor

RedCMD commented Mar 23, 2024

technically the problem is with VSCode, not this grammar
as the grammar correctly assigns both the italic and bold tokens
however VSCode only applies the last font style used

currently this can only be fixed by theme authors supplying a separate token for every single combination of font styles
underline, bold, italic, strikethrough and normal
and then this grammar would need to manually use the correct token for each combination of font styles
1 + 4 + 4*3 + 4*3*2 + 4*3*2*1 = 65 different font style combinations

@JesseSteele
Copy link

Passing the responsibility to the theme devs would mean that a standard way to handle this be required for a theme to listed. That's one way, but if it can be solved at a deeper level so theme devs could focus more on the actual style, that would seem to make more sense with dev specialization. Which course would need a decision from a PM.

@RedCMD
Copy link
Contributor

RedCMD commented Mar 26, 2024

maybe #160 should be moved back to VSCode as this is a VSCode issue, not Markdowns @mjbvz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

6 participants