BlockQuote while condition is incorrect, scoping doesn't match preview or GitHub #56
Labels
bug
Issue identified by VS Code Team member as probable bug
help wanted
Issues identified as good community contribution opportunities
Milestone
Copying comment from another repository: microsoft/vscode-textmate#110 (comment)
Example:
Actually (via GitHub):
VS Code Editor highlight:
From VS Code Preview:
I believe VS Code's Markdown grammar is wrong. The while rule is expecting to find additional lines starting with
>
but that is not how the previewer works. I believe the correct test is, at a minimum, a non-blank line. but possibly also tests for other kinds of markup, or precisely the same as thewhile
clause oflist_paragraph
. This is the correctwhile
condition forblockquote
:"while": "(^|\\G)([ ]{0,3}(>) ?|(?!\\s*$|#|[ ]{0,3}([-*_>][ ]{2,}){3,}[ \\t]*$\\n?|[ ]{0,3}[*+->]|[ ]{0,3}[0-9]+\\.))"
. With this change, I get the correct scoping.The text was updated successfully, but these errors were encountered: