Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running in Electron as Node aka support running in Node 19+ #114

Open
TylerLeonhardt opened this issue Jun 7, 2023 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality @vscode/l10n-dev
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Blocked on tree-sitter/tree-sitter-typescript#244

Tracks bumping our version of tree-sitter to a version that supports running in Node 19+

Workaround: Run @vscode/l10n-dev in Node 18 or lower. Btw, VS Code extensions still run in Node 16 as of today, so it's best to develop extensions using the same version...

@PF4Public
Copy link

So the day has come! Now that my distribution updated nodejs to 20 I can no longer build vscode.

@darkbasic
Copy link

:(

@PF4Public
Copy link

PF4Public commented Jun 11, 2023

My observations so far:

  • ✔️ net-libs/nodejs-18.16.0 OK
  • ❌ net-libs/nodejs-20.2.0 FAIL
  • ELECTRON_RUN_AS_NODE=1 electron-22 FAIL
  • ELECTRON_RUN_AS_NODE=1 electron-24 FAIL
  • ✔️ ELECTRON_RUN_AS_NODE=1 electron-25 OK

@TylerLeonhardt
Copy link
Member Author

@PF4Public I'd recommend using nvm or similar to get a different node version until this is sorted.

@PF4Public
Copy link

PF4Public commented Jun 12, 2023

@TylerLeonhardt Thank you for suggestion. It might be usable if I were to build vscode locally, but unfortunately it might be overly complicated to make it work under package manager, so I'd rather have a generic solution.

Surprisingly enough I could build vscode with electron-25 acting as node. Weird, but OK :)

PS: localizations work as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality @vscode/l10n-dev
Projects
None yet
Development

No branches or pull requests

3 participants