Add statusbar + toolbar item for selecting jupyter #4424
Conversation
| @@ -149,4 +148,7 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu | |||
| [DSCommands.SubmitGitHubIssue]: []; | |||
| [DSCommands.ShowDataViewer]: [IShowDataViewerFromVariablePanel]; | |||
| [DSCommands.ClearSavedJupyterUris]: []; | |||
| [DSCommands.SelectJupyterURI]: [undefined, 'toolbar' | undefined]; | |||
| [DSCommands.SelectNativeJupyterUriFromStatusBar]: []; | |||
| [DSCommands.SelectNativeJupyterUriFromToolBar]: []; | |||
There was a problem hiding this comment.
We seem to have a set of commands with arguments and a set without. Seems like these two new ones don't have arguments. But...does this matter? Not sure if I see a reason for the distinction.
There was a problem hiding this comment.
Also, why | undefined? Isn't 'commandPalette' or the other sources options?
There was a problem hiding this comment.
This is because SelectJupyterUri command can only be invoked from the command palette in which case the argument is undefiend.
The only other place its used is Interactive & WebView notebooks where we pass the argument toolbar to indicate its been invoked from the interactive/webview notebook toolbar.
Other than that there are no places where this command is invoked from.
We have similar commands that do the exact same thing, launch the UI. However we have separate commands so we can uniquely identify how and where those commands are launched. Pity we cannot use the same command with arguments (in VSC toolbar and statusbars).
I know in treeviews we can use commands with args.
There was a problem hiding this comment.
Hope that makes sense. The complication comes from the fact that we want to identify the differnt places the same command is launched, hence duplicate commands.
There was a problem hiding this comment.
Oh wait, just found we can use args in the statusbar.
There was a problem hiding this comment.
Fixed by removing one of the duplicate commands.
| this.statusBarItem.show(); | ||
| const uri = await this.serverUriStorage.getUri(); | ||
| const label = | ||
| uri === Settings.JupyterServerLocalLaunch |
There was a problem hiding this comment.
For remote we're not showing the URI? It's just going to say 'jupyter server: remote'?
There was a problem hiding this comment.
Yes, else we end up taking a whole lot of space in the status bar.
Ooops, I'm meant to display the Uri in the tooltip.
Codecov Report
@@ Coverage Diff @@
## main #4424 +/- ##
======================================
Coverage 75% 75%
======================================
Files 392 397 +5
Lines 25746 25924 +178
Branches 3680 3709 +29
======================================
+ Hits 19407 19615 +208
+ Misses 4826 4799 -27
+ Partials 1513 1510 -3
|
For #254