Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame working in web extension #9665

Closed
Tracked by #9574
rchiodo opened this issue Apr 11, 2022 · 2 comments · Fixed by #10825
Closed
Tracked by #9574

DataFrame working in web extension #9665

rchiodo opened this issue Apr 11, 2022 · 2 comments · Fixed by #10825
Assignees
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Apr 11, 2022

Only difficulty might be in getting the dataframe scripts to run on the remote jupyter machine.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Apr 11, 2022
@greazer greazer added work item and removed bug Issue identified by VS Code Team member as probable bug needs-triage labels Apr 14, 2022
@sadasant sadasant added this to the June 2022 milestone Jun 3, 2022
@greazer greazer changed the title DataFrame/PlotViewer working in web extension DataFrame working in web extension Jun 9, 2022
@sadasant
Copy link
Contributor

How is this going:

  • On PR (now closed) Web version of the DataFrame #10545 I submitted a version that did work on the web as well as on Node.js, however it did not work in the web in the scenarios where the debuggers allowed inspecting variables in the data viewer.
    • I did try to get it to work with the debuggers, but I couldn't, because running the commands to get the version of pandas was not giving me any result with the debugger, so I undid the debug work initially.
    • I thought I could still get it merged that way, because it would be still allowing the data viewer to work generally on the web, and the web scenario for the debugger's data viewer isn't working currently anyway.
    • But the team helped me realize that the correct step would be to either finish this with the debugger support, or to disable the debugger feature to inspect in the data viewer.
    • I decided to finish the debugger support.
  • So, I closed the PR and I'm working on finishing the debugger support here: https://github.com/sadasant/vscode-jupyter/tree/web/9665-6
    • At the moment, most of the code changes are done.
    • However, for the debugger features, either I'm doing something really dumb or there's some unknown bug with the debugger that is preventing it from sending me responses.

I'm getting some help from the team and it is possible I will finish today, but it all depends on the underlying reason of my issue with the debugger.

@sadasant
Copy link
Contributor

After meeting with @DonJayamanne and @rchiodo , we now have a path forward regarding this issue.

Our priority is to solve this issue, so first we will make sure to enable the Data Frame viewer on the web:

  • By changing the IDataViewerDependencyService to receive an IKernel besides the PythonEnvironment that it receives today.
  • By adding a universal version of the dataViewerDependencyService that would only work if IKernel is provided and throw otherwise an error saying Installation of "pandas" not supported while debugging. Please ensure you have "pandas" installed.
  • By keeping the current node-specific version of the dataViewerDependencyService that would extract the interpreter from the IKernel if the IKernel is provided.
  • Besides ensuring the dataViewerDependencyService is registered on the web service registry, and removing the conditional that disables the Data Frame on the web.

This approach is a compromise of a more valuable set of changes, which will come with other PRs. You can see the current plan at: #10638

@rchiodo rchiodo modified the milestones: June 2022, July 2022 Jul 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.