Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter session names no longer shown in kernel picker #8175

Closed
zpincus opened this issue Nov 5, 2021 · 1 comment
Closed

Jupyter session names no longer shown in kernel picker #8175

zpincus opened this issue Nov 5, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release notebook-remote Applies to remote Jupyter Servers

Comments

@zpincus
Copy link

zpincus commented Nov 5, 2021

Environment data

  • VS Code version:
Version: 1.62.0 (Universal)
Commit: b3318bc0524af3d74034b8bb8a64df0ccf35549a
Date: 2021-11-03T15:24:41.297Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0
  • Jupyter Extension version (available under the Extensions sidebar): v2021.10.1001414422
  • Python Extension version (available under the Extensions sidebar): v2021.11.1422169775
  • OS (Windows | Mac | Linux distro) and version: MacOS 11.6
  • Jupyter server running: Remote

Expected behaviour

When using a "remote" jupyter server, the "kernel picker" window allows you to choose among all the running sessions on the server to connect a notebook to. In the previous version of the Jupyter extension, the names of these kernels were shown, along with a clear indication of which was currently selected.

Actual behaviour

In the new version of the extension, the names are no longer shown, requiring a user to guess as to which session to (re)connect to. Moreover, the "currently selected" text showing which session is connected, is often almost or completely obscured. Both are illustrated below. (Only in the second screenshot can the "currently selected" text be seen at all, cut off as "Cu..." on the very right side of the top line...)

image

image

Also, the "last activity" text doesn't seem to update correctly; I just now re-ran a cell in the notebook, but the text remains unchanged for the currently connected session. (This also applies to the "0 existing connections" text; one might expect that the "currently selected" notebook would show up as having "1 existing connection", but no.)

This behavior pairs particularly badly with #7610, but even if that were fixed, what's the point of letting you choose among sessions if you have to guess which is which?

@zpincus zpincus added the bug Issue identified by VS Code Team member as probable bug label Nov 5, 2021
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Nov 5, 2021

Here's the update, will submit a PR
image

@greazer greazer closed this as completed Nov 8, 2021
@greazer greazer added the candidate Issue identified as probable candidate for fixing in the next release label Nov 8, 2021
@greazer greazer added this to the October 2021 Recovery milestone Nov 8, 2021
@greazer greazer added notebook-remote Applies to remote Jupyter Servers and removed needs-triage labels Nov 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release notebook-remote Applies to remote Jupyter Servers
Projects
None yet
Development

No branches or pull requests

4 participants