Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting ESC in kernel picker step does not dismiss whole quick pick #12887

Closed
isidorn opened this issue Feb 21, 2023 · 2 comments
Closed

Hitting ESC in kernel picker step does not dismiss whole quick pick #12887

isidorn opened this issue Feb 21, 2023 · 2 comments
Assignees

Comments

@isidorn
Copy link

isidorn commented Feb 21, 2023

Testing #11904

  1. Go into the kernel picker
  2. Select Python Environments
  3. Select the option to create a new Environment,
  4. Select Venv
  5. Press esc -> quick pick is not dismissed. I am just taken to the previous step

This might be expected behaviour of multi step quick pick (@TylerLeonhardt ?). But in the test plan item you mentioned that this is not expected, thus I am creating this issue just in case.

@DonJayamanne
Copy link
Contributor

@isidorn sorry, I hadn't merged the changes at the time, did not realize that.
Please could you test this once again with the latest pre-release bits in vscode insiders.

@isidorn
Copy link
Author

isidorn commented Feb 22, 2023

Thank you. I have tested it out and it works as expected. Thus closing.

@isidorn isidorn closed this as completed Feb 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants