Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Run all cells" ignores exceptions #1252

Closed
logan-pugh opened this issue Jun 13, 2020 · 2 comments
Closed

"Run all cells" ignores exceptions #1252

logan-pugh opened this issue Jun 13, 2020 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@logan-pugh
Copy link

I noticed there is a difference in behavior between running all cells in a notebook in Jupyter Lab/Notebook and VS Code: when an exception is raised in Jupyter Lab/Notebook, subsequent cells do not run. In VS Code, all cells run regardless of whether any exceptions were raised.

I am sure the former is the correct behavior so can this be considered a bug in the VS Code Python extension? I also see that VS Code itself is adding native notebook support so perhaps this will be addressed in that but I wanted to be sure this issue was recorded somewhere.

I've also verified the same behavior in the latest VS Code Insiders (1.47.0).

Thanks!

@IanMatthewHuff
Copy link
Member

@logan-pugh thanks for filing this. I took a look and confirm the same thing that you are seeing. We will discuss this internally, but we probably want to match the way Jupyter behaves here.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug temp-nice-for-october labels Nov 13, 2020
@greazer greazer added the P2 label Nov 14, 2020
@greazer
Copy link
Member

greazer commented Jun 6, 2021

Thanks for your feedback. This issue will be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987. You can experiment by using VS Code insiders, which defaults to the new notebook experience.

@greazer greazer closed this as completed Jun 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants