Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve remote jupyter server CORS warning/error message prompt #12507

Closed
DonJayamanne opened this issue Jan 9, 2023 · 5 comments
Closed

Improve remote jupyter server CORS warning/error message prompt #12507

DonJayamanne opened this issue Jan 9, 2023 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

TODO:

  • Provide ability for 3rd party Jupyter Server providers the ability to provide custom protocols for Web Sockets.

Other?

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Jan 9, 2023
@DonJayamanne DonJayamanne self-assigned this Jan 9, 2023
@DonJayamanne DonJayamanne added this to the January 2023 milestone Jan 9, 2023
@DonJayamanne
Copy link
Contributor Author

Improve UX in remote URL input for vscode.dev (able to copy url, etc)

@DonJayamanne
Copy link
Contributor Author

The following UX needs to be improved

  • The URL cannot be copied
  • Error message with link is not where the validation error message is displayed (disconnected UX)
  • Check with @TylerLeonhardt what can be done to add links (commands) to the validation error message

MicrosoftTeams-image (1)
MicrosoftTeams-image

@TylerLeonhardt
Copy link
Member

Check with @TylerLeonhardt what can be done to add links (commands) to the validation error message

That's tracked with microsoft/vscode#82112

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Feb 13, 2023

  • Add ability to copy the URL if there is one in the error message
  • Display a link for the URL in the error message
  • Display a tooltip or the like for quick pick item Install Python
  • :deferred: Display a tooltip or the like for quick pick item that correspond to Conda environments without Python

@DonJayamanne
Copy link
Contributor Author

Verification steps:

  • Use VS Code insiders
  • Go into kernle picker and select Eixisting Jupyter Server
  • Attempt to add an invalid URL
  • The error message should contain the URL and it should be a link that can be clicked.

@rzhao271 rzhao271 added verified Verification succeeded and removed blocked labels Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants