Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Kernel Spec is a dead end #12224

Closed
jrieken opened this issue Nov 30, 2022 · 6 comments · Fixed by #12517
Closed

Local Kernel Spec is a dead end #12224

jrieken opened this issue Nov 30, 2022 · 6 comments · Fixed by #12517
Assignees
Labels
notebook-kernel-picker polish Cleanup and polish issue
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Nov 30, 2022

Testing #11963

  • selected "Select Another Kernel > Local Kernel Spec"
  • I see an empty QP with nothing

I honest don't really know "Local Kernel Spec" is all about but I'd suggest to (1) don't give me that option to begin with or (2) show a message why this is empty and how I can populate it

Screenshot 2022-11-30 at 11 36 23

@DonJayamanne
Copy link
Contributor

show a message why this is empty and how I can populate it

should add an item with an information link as suggested my @amunger

@roblourens

This comment was marked as resolved.

@DonJayamanne DonJayamanne added the polish Cleanup and polish issue label Nov 30, 2022
@DonJayamanne

This comment was marked as resolved.

@roblourens
Copy link
Member

we need to be consistent, either always show or always hide. not show/hide dynamically at different points in time.

Is that not exactly what we are doing with the kernel picker now, as kernels get lazily discovered and loaded into the picker? I don't see the problem.

re: an info link, are kernel specs a really useful feature that we want to educate users on? If not, then why add a link on how to add kernel specs? I would expect that a user who needs to create kernel specs already understands this functionality.

@DonJayamanne
Copy link
Contributor

Is that not exactly what we are doing with the kernel picker now, as kernels get lazily discovered and loaded into the picker? I don't see the problem.

If we wait for kernel to be discovered, then lazy loading is pointless (and will be slower to display this item)
today we register the Selct a Local Kernle Spec entry with vscode as soon as the extwension activates

@DonJayamanne
Copy link
Contributor

Solution: Display this item only when we have discovered local kernelspecs

@DonJayamanne DonJayamanne added this to the December 2022 milestone Dec 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook-kernel-picker polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants