Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some actions in vega viewer do not work #11294

Closed
DonJayamanne opened this issue Sep 6, 2022 · 1 comment
Closed

Some actions in vega viewer do not work #11294

DonJayamanne opened this issue Sep 6, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@DonJayamanne
Copy link
Contributor

The following actions do not work in vega viewer:

  • View Source
  • Open in Vega Editor

Thoughts:

  • Do we know how many try using this feature?
  • What if we were to just disable these two in the custom renderer?
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Sep 6, 2022
@DonJayamanne DonJayamanne self-assigned this Sep 6, 2022
@DonJayamanne
Copy link
Contributor Author

They have been disabled,
Testing instructions:

  • Install latest VS Code Insiders, Jupyter pre-release and Notebook renderers extension
  • Install the following python packages
    pip install altair, vega, vega-datasets
  • Run a cell in a notebook
import altair as alt
from vega_datasets import data

# Show an image where the interactive plot is not supported
alt.renderers.enable('mimetype')

source = data.cars()

alt.Chart(source).mark_boxplot().encode(
    x='Origin',
    y=alt.Y(alt.repeat('column'), type='quantitative'),
).repeat(column=['Horsepower', 'Weight_in_lbs'])
  • Click on the hamburger menu and you should only get the options Save as PNG & SVG
    Screen Shot 2022-09-27 at 08 33 44

@DonJayamanne DonJayamanne added this to the September 2022 milestone Sep 26, 2022
@mjbvz mjbvz added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants