Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show unclickable links in dialogs #11285

Closed
kieferrm opened this issue Sep 4, 2022 · 1 comment · Fixed by #11378
Closed

Don't show unclickable links in dialogs #11285

kieferrm opened this issue Sep 4, 2022 · 1 comment · Fixed by #11378
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@kieferrm
Copy link
Member

kieferrm commented Sep 4, 2022

image

We usually show "Learn more..." buttons instead.

@IanMatthewHuff
Copy link
Member

Validation notes:

This is for a server error with the web extension. You need to be running web, and then you can just try to connect to a junk server name to test it.

The UI varies a bit based on if you are on the kernel picker experiment or not. I've fixed both scenarios.

With jupyter.showOnlyOneTypeOfKernel on, the modal dialog shown above will be replaced with a non-modal error dialog with different wording. With that value false you will get a general server connected error in the validation box, and a non-modal error that gives information specific to the web failure connection case.

@mjbvz mjbvz added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
3 participants