Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flame chart doesn't use charts foreground color #780

Closed
roblourens opened this issue Sep 30, 2020 · 1 comment
Closed

Flame chart doesn't use charts foreground color #780

roblourens opened this issue Sep 30, 2020 · 1 comment
Assignees
@connor4312
Labels
*as-designed Described behavior is as designed

Comments

@roblourens
Copy link
Member

From #756

image

Also - does any token change the gray? I can imagine a theme wanting to customize that.
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Sep 30, 2020
@connor4312
Copy link
Member

connor4312 commented Sep 30, 2020 •
edited
Loading

The chart foreground color is the text color on charts. The base color of the chart is charts.red. We don't use the foreground color for the text drawn over the bars, since that foreground color is meant to contrast with the editor background rather than the chart color. Instead, we adjust the luminance of charts.red so that white is always contrasting-enough on the chart background.

@connor4312 connor4312 added *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @connor4312