Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview wrapper debug state gets out of sync #664

Closed
lramos15 opened this issue Jul 27, 2020 · 2 comments
Closed

Webview wrapper debug state gets out of sync #664

lramos15 opened this issue Jul 27, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@lramos15
Copy link
Member

Describe the bug
Sometimes the wrapper is out of sync with the processes list below it
image
image

To Reproduce
Steps to reproduce the behavior:

  1. Set a bunch of breakpoints in various ext host functions
  2. Press continue you will see sometimes the state is in sync other times it isn't

Log File
vscode-debugadapter-0.json.gz
vscode-debugadapter-1.json.gz

VS Code Version: Version:
1.48.0-insider (user setup)
Commit: 731f9c25632dbbf01ee3a7892ad9d2791fe0260c
Date: 2020-07-24T05:57:10.466Z
Electron: 9.1.0
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

Additional context
On JS-debug nightly

@lramos15 lramos15 added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2020
@connor4312
Copy link
Member

connor4312 commented Aug 12, 2020

I noticed this is actually an issue in VS Code -- VS code wants to hide the badge of the parent session when it's no paused and has no children. I fixed this, but I wonder if maybe we should always show "running" now that we have compact sessions (so debuggers can generally hide logical wrapper sessions). cc @isidorn

Verifiers: you can repro this by having a node.js process that spawns a child. Pause and then continue in the child, you'll notice the parent session's badge state is not reset 🐛

@isidorn
Copy link

isidorn commented Aug 13, 2020

@connor4312 yes, I think we could always show the running badge. Can you file an issue for this? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants