Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix: Rebuild after running "Go Get Package" #2129

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix: Rebuild after running "Go Get Package" #2129

merged 1 commit into from
Nov 28, 2018

Conversation

Ashniu123
Copy link
Contributor

Fixes issue #2087

@Ashniu123
Copy link
Contributor Author

Any idea why test should be failing?

ramya-rao-a
ramya-rao-a suggested changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will build the code only if go get fails. Dont we want to build the code only after go get succeeds?

@Ashniu123
Copy link
Contributor Author

On line 28, it is written that

// go get -v uses stderr to write output regardless of success or failure

From this I thought that if go get fails then error will remain, which is fine.
And if it is a success, build will be successful and error will go away.

@ramya-rao-a
Copy link
Contributor

Good point!

@ramya-rao-a ramya-rao-a merged commit 3f20049 into microsoft:master Nov 28, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Nov 28, 2018 •
edited
Loading

Looks like this is your first PR in this project, Thanks & Welcome!

Feel free to pick up any other issue with the help-wanted label. I appreciate all the help I can get :)

@Ashniu123 Ashniu123 deleted the rebuild-go-get branch November 28, 2018 07:40
@ramya-rao-a ramya-rao-a mentioned this pull request Dec 2, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashniu123 @ramya-rao-a