This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix 'Debug: Start Without Debugging' to use current file and include buildFlags/args #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycekahle
commented
Nov 13, 2018
| @@ -209,6 +209,7 @@ interface LaunchRequestArguments extends DebugProtocol.LaunchRequestArguments { | |||
| dlvToolPath: string; | |||
| /** Delve Version */ | |||
| apiVersion: number; | |||
| currentFile: string; | |||
There was a problem hiding this comment.
@ramya-rao-a This was the only way to pass along currentFile, but this is obviously not configuration. Is it OK to not have currentFile in the schema in package.json?
There was a problem hiding this comment.
Yes, its ok. In this case, this is an internal implementation. Current file can always be determined by VS Code using the vscode.window.activeTextEditor. It need not be provided by the user
brycekahle
changed the title
|
The latest CI failure does not appear to be related. |
ramya-rao-a
approved these changes
Nov 21, 2018
|
Thanks @brycekahle! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include buildFlags and args when running without debugging. Use current file (if there is one) when 'running without debugging'.
Fixes #2086 and #2085