This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Map remote goroot to local goroot #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
changed the title
roblourens
reviewed
Sep 1, 2017
src/debugAdapter/goDebug.ts
Outdated
| // Fix for https://github.com/Microsoft/vscode-go/issues/1178 | ||
| // When the pathToConvert is under GOROOT, replace the remote GOROOT with local GOROOT | ||
| if (!pathToConvert.startsWith(this.delve.remotePath)) { | ||
| let index = pathToConvert.indexOf('src'); |
There was a problem hiding this comment.
This is supposed to be /src/ in the goroot, right? It could match a different src, like /Users/src/goroot/src/...
There was a problem hiding this comment.
Updated to match /src/
roblourens
reviewed
Sep 1, 2017
src/debugAdapter/goDebug.ts
Outdated
| return path.join(goroot, ...pathToConvert.substr(index).split(this.remotePathSeparator)); | ||
| } | ||
| } | ||
| return pathToConvert.replace(this.delve.remotePath, this.delve.program).split(this.remotePathSeparator).join(this.localPathSeparator); |
There was a problem hiding this comment.
You use path.join above and .join(this.localPathSeparator); here, should it be the same?
There was a problem hiding this comment.
path.join uses the path separator for the local machine so it would be the same localPathSeparator
additionally it also takes care of trailing / at the end of goroot if there is any.
So if I do a split on the goroot, remove trailing / if it exists, then I can use .join(this.localPathSeparator)
roblourens
approved these changes
Sep 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1178
See #1178 (comment)