Implement drag and drop controller #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
requested changes
May 31, 2021
alexr00
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
@barbaravaldez I have made some changes. Please let me know if they look ok to you!
Looks good to me! Thank you, @alexr00 😃 |
tamuratak
pushed a commit
to tamuratak/vscode-extension-samples
that referenced
this pull request
Apr 29, 2022
* implement drag and drop in sample * clean code * fix reveal command * remove unnecessary method * fix getParent to return the existing node instead of creating a new key * Linting, naming, etc. Co-authored-by: Alex Ross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag and drop implementation in sample tree view.
I had to modify the getChildren and getParent method since they wouldn't work when reparenting elements.
I implemented the dataProvider and dragAndDropController in the TestView class instead of passing them as functions to simplify the code.
https://user-images.githubusercontent.com/34872381/119911928-3801f880-bf0f-11eb-8505-c3fae098559b.mov