Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.eslintignore is completely ignored #198

Closed
cubodehelio opened this issue Feb 6, 2017 · 2 comments
Closed

.eslintignore is completely ignored #198

cubodehelio opened this issue Feb 6, 2017 · 2 comments

Comments

@cubodehelio
Copy link

cubodehelio commented Feb 6, 2017 •
edited
Loading

  • vscode-eslint: v1.2.3
  • eslint: v3.15.0
  • vscode v1.9.0
  • linux mint 17

The .eslintignore file is in the root of the project. eslint cli is installed in the workspace and works as expected running node_modules/.bin/eslint . but the VSC extension keeps linting all directories including the ignored once and even node_modules!

.eslintignore

public/*
build/*
@dbaeumer
Copy link
Member

dbaeumer commented Feb 7, 2017

I can reproduce this. With the fix I did now an .eslintignore file in the build directory is honored but not a single global one anymore. Need to investigate.

@dbaeumer
Copy link
Member

dbaeumer commented Feb 7, 2017

I will revert the fix with setting the cwd for now since I think this broke quite some use cases which worked before.

@dbaeumer dbaeumer mentioned this issue Feb 7, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaeumer @cubodehelio