Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ESLint to VS Code's Workspace Trust Model #1237

Closed
dbaeumer opened this issue Apr 13, 2021 · 1 comment
Closed

Adapt ESLint to VS Code's Workspace Trust Model #1237

dbaeumer opened this issue Apr 13, 2021 · 1 comment
Milestone
2.1.22

Comments

@dbaeumer
Copy link
Member

The ESLint extension should make use of VS Code's workspace trust model.
@dbaeumer dbaeumer added this to the 2.1.21 milestone Apr 13, 2021
@dbaeumer
Copy link
Member Author

dbaeumer commented Apr 13, 2021 •
edited
Loading

⚠️⚠️⚠️⚠️

Only test the new version if you are familiar with VS Code's new trust model and are running on VS Code's latest insider

How to test:

  • enable VS Code's trust model using the USER setting "security.workspace.trust.enabled": true
  • Download vscode-eslint-2.1.21.zip
  • Rename vscode-eslint-2.1.21.zip to vscode-eslint-2.1.21.vsix
  • Install the VSIX using the Install from VSIX command

What changed:

  • ESLint will not start anymore on untrusted workspaces.
  • if started on a trusted Workspace no ESLint custom dialogs, notifications or setting pickers will be used.

This was referenced Nov 5, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.22
Development

No branches or pull requests
1 participant
@dbaeumer