docker-in-docker broken after upgrading from universal:0-linux to universal:1-linux

[jeremymeng]

• VSCode Version:
• Local OS Version:
• Reproduces in: Codespaces
• Name of Dev Container Definition with Issue: codespaces-linux

Development container image information

• Image version: 1.6.3
• Definition ID: codespaces-linux
• Source code repository: https://github.com/microsoft/vscode-dev-containers/
• Source code release/branch: v0.191.1
• Timestamp: Fri, 13 Aug 2021 23:23:36 GMT

More info: https://github.com/microsoft/vscode-dev-containers/tree/main/containers/codespaces-linux/history/1.6.3.md

Steps to Reproduce:

1. create a Codespace at https://github.com/Azure/azure-sdk-for-js
2. start the Codespace
3. open a terminal then type docker ps

Error:
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

[jeremymeng]

Azure/azure-sdk-for-js#17296

[Chuxel]

When upgrading from 0-linux to 1-linux, you need to add --privileged to runArgs in devcontainer.json for Docker to continue to function. I can see that's missing from the devcontainer.json file in that repository so you'll hit a permission error (that you can see in /tmp/dockerd.log).

If you want to retain your containers across "rebuilds", you should also add the following to mounts:

"mounts": ["source=codespaces-linux-var-lib-docker,target=/var/lib/docker,type=volume"],

Let us know if you still see a problem.

[jeremymeng]

@Chuxel Thanks a lot for the help!