Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to camelCase for Default, Enabled, Disabled #9862

Merged
merged 15 commits into from
Sep 20, 2022
Merged

change to camelCase for Default, Enabled, Disabled #9862

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
14f2cc2
change to camelCase for Default, Enabled, Disabled
browntarik Sep 8, 2022
66b0dbb
address all comparison issues and refs to Default
browntarik Sep 8, 2022
feae362
address all comparison issues and refs to Default
browntarik Sep 8, 2022
320d355
resolve PR
browntarik Sep 13, 2022
98bfb54
resolve PR
browntarik Sep 16, 2022
f0ecdd4
refactor enabled/disabled to booleans and casing
browntarik Sep 16, 2022
a8694b5
fix build errors
browntarik Sep 16, 2022
c2ca699
Merge branch 'main' into browntarik/changePascalCase
browntarik Sep 16, 2022
28762c4
resolve PR
browntarik Sep 19, 2022
304a336
Merge branch 'browntarik/changePascalCase' of https://github.com/Micr…
browntarik Sep 19, 2022
65fcb15
change intellisense engine to lowercase not bool
browntarik Sep 19, 2022
3ee2640
missed one
bobbrow Sep 20, 2022
518ea5b
support experimentalFeatures
browntarik Sep 20, 2022
46944da
Merge branch 'browntarik/changePascalCase' of https://github.com/Micr…
browntarik Sep 20, 2022
f611df2
change intellisense engine values
browntarik Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,11 +2158,11 @@
"C_Cpp.intelliSenseEngine": {
"type": "string",
"enum": [
"Default",
"default",
"Tag Parser",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the "Tag Parser" enum? That seems inconsistent now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be "tagParser"? The C++ side might need updating.

"Disabled"
"disabled"
],
"default": "Default",
"default": "default",
"description": "%c_cpp.configuration.intelliSenseEngine.description%",
"enumDescriptions": [
"%c_cpp.configuration.intelliSenseEngine.default.description%",
Expand Down