Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Semantic Tokens API #5401

Merged
merged 31 commits into from
Jul 1, 2020
Merged

Switch to Semantic Tokens API #5401

merged 31 commits into from
Jul 1, 2020

Conversation

Colengms
Copy link
Contributor

@Colengms Colengms commented May 1, 2020

(Recreating PR from the correct account)

  • Removes previous semantic colorization implementation.
  • Adds a SemanticTokensProvider.
  • Restores implementation of inactive regions from prior to being merged with semantic colorization.
  • VS Code version dependency is increased to 1.44.0

michelleangela
michelleangela suggested changes May 4, 2020
View reviewed changes
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
Extension/src/LanguageServer/client.ts Show resolved Hide resolved
@bobbrow bobbrow added this to the 0.29.0 milestone May 11, 2020
J-Fields
J-Fields reviewed Jun 12, 2020
View reviewed changes
Themes/README.md Outdated Show resolved Hide resolved
@Colengms Colengms merged commit f7165ba into master Jul 1, 2020
@Colengms Colengms deleted the coleng/semantic_tokens branch July 1, 2020 21:48
@sslupsky sslupsky mentioned this pull request Jul 12, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@J-Fields J-Fields J-Fields left review comments

@michelleangela michelleangela michelleangela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Colengms @J-Fields @sean-mcmanus @michelleangela @bobbrow