Change how logging level is passed to native process #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
michelleangela
previously approved these changes
Sep 18, 2023
…nto coleng/safe_json
sean-mcmanus
approved these changes
Sep 18, 2023
michelleangela
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a corresponding PR on the native side to enable a 'safe' mode for JSON deserialization, in which failed parsing of node does not fail the entire deserialization. This should address the crashes currently related to: #11375
That change also adds logging of the node that failed to deserialize. However, the logging level was not being evaluated until after the cpptools initialization message (containing it) has been deserialized, so any failures in that initial message (including all settings), were not being logged at the right level. So, this change is part of setting that logging level earlier on the native side by passing the logging level up in the initial LSP initialization message, before the CppTools initialization/settings message.
Also changed an existing cache of the
loggingLevelvalue to use its numeric form.