Disable AutoPCH early on platforms that don't support it #11362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
sean-mcmanus
approved these changes
Aug 25, 2023
sean-mcmanus
previously approved these changes
Aug 25, 2023
sean-mcmanus
approved these changes
Aug 25, 2023
michelleangela
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address: #11315 , #10789
The IntelliSense process should automatically detect when AutoPCH is not supportable (on platforms that don't support disabling ASLR/PIE). We've had reports of issues on M1 Mac that are addressed by disabling the IntelliSense cache, suggesting fallback does not always work as expected. It's actually more efficient to disable the cache early on platforms we know do not support it, rather than wait for the fallback to occur.