Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler acquisition #11286

Merged
merged 19 commits into from
Sep 13, 2023
Merged

Compiler acquisition #11286

merged 19 commits into from
Sep 13, 2023

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Aug 3, 2023

Add a new "Install Compiler" command accessible through the walkthrough and the configure IntelliSense quickpick. On majority distros of linux and macOS it will run the commands necessary to install a default c++ compiler for you. On Windows, it will show the command needed to install MSVC on the PC, giving the user a chance to attest their license (other compiler options are also shown).

@bobbrow bobbrow enabled auto-merge (squash) August 4, 2023 22:57
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this wait for 1.18.0 for localization? Otherwise, won't the walkthrough be inconsistently localized?

@bobbrow
Copy link
Member Author

bobbrow commented Aug 8, 2023

Should this wait for 1.18.0 for localization? Otherwise, won't the walkthrough be inconsistently localized?

Yes, I'm holding this for 1.18 because of localization.

@bobbrow bobbrow added this to the 1.18 milestone Aug 8, 2023
@sean-mcmanus sean-mcmanus modified the milestones: 1.18, 1.18.0 Aug 11, 2023
@bobbrow bobbrow dismissed sean-mcmanus’s stale review August 15, 2023 21:34

1.17 is released

@bobbrow bobbrow disabled auto-merge August 15, 2023 21:34
Colengms
Colengms previously approved these changes Aug 18, 2023
@bobbrow bobbrow enabled auto-merge (squash) August 18, 2023 21:58
Extension/src/LanguageServer/extension.ts Outdated Show resolved Hide resolved
@bobbrow bobbrow dismissed sean-mcmanus’s stale review September 8, 2023 23:49

feedback addressed

@bobbrow bobbrow requested a review from a team September 8, 2023 23:49
@bobbrow bobbrow linked an issue Sep 12, 2023 that may be closed by this pull request
@bobbrow bobbrow merged commit 2715319 into main Sep 13, 2023
4 checks passed
@bobbrow bobbrow deleted the bobbrow/acquisition branch September 13, 2023 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler Acquisition
4 participants