-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler acquisition #11286
Merged
Merged
Compiler acquisition #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
commented
Aug 3, 2023
sean-mcmanus
reviewed
Aug 4, 2023
sean-mcmanus
approved these changes
Aug 4, 2023
sean-mcmanus
previously requested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this wait for 1.18.0 for localization? Otherwise, won't the walkthrough be inconsistently localized?
Yes, I'm holding this for 1.18 because of localization. |
Colengms
previously approved these changes
Aug 18, 2023
sean-mcmanus
previously requested changes
Aug 23, 2023
Colengms
approved these changes
Sep 8, 2023
Closed
michelleangela
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "Install Compiler" command accessible through the walkthrough and the configure IntelliSense quickpick. On majority distros of linux and macOS it will run the commands necessary to install a default c++ compiler for you. On Windows, it will show the command needed to install MSVC on the PC, giving the user a chance to attest their license (other compiler options are also shown).