Added IAR problem matcher (#10054) #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
requested changes
Oct 31, 2022
sean-mcmanus
requested changes
Oct 31, 2022
morsisko
force-pushed
the
iar_problem_matcher
branch
from
ac5966c to
fb8706f
Compare
|
Requested changes has been implemented |
sean-mcmanus
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds IAR problem matcher.
Warning example that is generated by IAR compiler:
"D:\iar_test\main.c",6 Warning[Pe177]: variable "c" was declared but never referencedThere is one thing that needs to be said (not sure if it is issue or not). By default for some reasons IAR splits the error/warning message over multiple lines, if the message is too long. In such case problem matcher will catch only the first part of the message, for example:
However, there is an option that can be passed to IAR -
--no_wrap_diagnosticsin such situation the problem matcher works without any problem.I tried to use the multiline problem matcher, however this doesn't look good in my opinion, plus from what I see the IAR message may be split over multiple lines (more than two), so it would be hard or even impossible to implement such problem matcher.
In my opinion best idea is to leave it as in my pull request. If someone want to get the whole message, they should use the
--no_wrap_diagnosticsIAR option.