Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with call to cpptools-wordexp with invalid arguments #10070

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix issue with call to cpptools-wordexp with invalid arguments #10070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Extension/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,12 +1012,12 @@ function extractArgs(argsString: string): string[] {
}
return result;
} else {
const wordexpResult: any = child_process.execFileSync(getExtensionFilePath("bin/cpptools-wordexp"), [argsString]);
if (wordexpResult === undefined) {
return [];
}
const jsonText: string = wordexpResult.toString();
try {
const wordexpResult: any = child_process.execFileSync(getExtensionFilePath("bin/cpptools-wordexp"), [argsString], { shell: false });
if (wordexpResult === undefined) {
return [];
}
const jsonText: string = wordexpResult.toString();
return jsonc.parse(jsonText, undefined, true);
} catch {
return [];
Expand Down