Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doxygen comment generation with the /** style doesn't have the end */ aligned #9758

Closed
sean-mcmanus opened this issue Aug 19, 2022 · 3 comments
Closed

Doxygen comment generation with the /** style doesn't have the end */ aligned #9758

sean-mcmanus opened this issue Aug 19, 2022 · 3 comments
Assignees
@sean-mcmanus
Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone
1.12.2

Comments

@sean-mcmanus
Copy link
Contributor

It's great that you added support for generating doxygen comments.

Just noted a little inconsistency: When generating a Javadoc style doxygen comment that starts with /**, the indention of the final asterisk is not in line with the asterisks on the lines above it, as is normally the case.

image

Originally posted by @Spaark84 in #5683 (comment)
@sean-mcmanus sean-mcmanus added Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. bug Language Service Visual Studio Inherited from Visual Studio labels Aug 19, 2022
@sean-mcmanus
Copy link
Contributor Author

@Spaark84 The issue is inherited from VS 2022.

@sean-mcmanus sean-mcmanus self-assigned this Aug 19, 2022
@sean-mcmanus sean-mcmanus added quick fix and removed Visual Studio Inherited from Visual Studio labels Aug 19, 2022
@sean-mcmanus sean-mcmanus added this to the 1.12.2 milestone Aug 19, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 19, 2022
@sean-mcmanus
Copy link
Contributor Author

I filed VS bug https://developercommunity.visualstudio.com/t/C-IntelliSense-doxygen-comment-with-/10126079 , but it turns out our VS Code implementation of the end */ isn't shared with VS so we fixed it.

@sean-mcmanus
Copy link
Contributor Author

Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/v1.12.2

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug Feature: Doc comments An issue related to code comments shown in hover, completion, and signature help. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Milestone
1.12.2
Development

No branches or pull requests
1 participant
@sean-mcmanus