Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to enable caching of Find All References clients for non-opened files #4038

Closed
sean-mcmanus opened this issue Aug 9, 2019 · 3 comments
Labels
Feature: Find All References Find All References, Peek References, Rename Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance Works in VS So we'd need to fix it for VS Code to reach parity.

Comments

@sean-mcmanus
Copy link
Contributor

Currently, IntelliSense clients are only kept around for opened files. In VS, they are also kept around from the clients created from Find All References, based on a setting and in some cases memory usage.

The current workaround is to open any files if you want Find All References to be faster for those files....but if memory goes over 1 GB we'll start to close clients, so we may want to improve that as well.

@sean-mcmanus sean-mcmanus added Language Service Feature Request more votes needed Issues that have been postponed until more community members upvote it Works in VS So we'd need to fix it for VS Code to reach parity. Feature: Find All References Find All References, Peek References, Rename labels Aug 9, 2019
@Lennon925
Copy link

Currently it's slow to find all references if there are many code files in your project. It will be better if it can find references faster.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Aug 20, 2019

To be more specific, doing this change would only decrease the time it takes in the "confirming" phase when the same file has to be confirmed that was already confirmed in a previous Find All References operation. But if you did 2 Find All References that had to confirm references in 16 different files, then there would be no speed up. The speed up would be equivalent to the speed up a user would gain via manually opening the files with references before doing a Find All References (assuming the clients aren't close due to memory usage).

@bobbrow bobbrow modified the milestones: Backlog, Post-v1 Mar 19, 2020
@bobbrow bobbrow modified the milestones: Post-v1, Backlog Jul 28, 2020
@Colengms Colengms removed the more votes needed Issues that have been postponed until more community members upvote it label Oct 16, 2020
@sean-mcmanus sean-mcmanus modified the milestones: Backlog, 1.8.0-insiders Nov 24, 2021
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 24, 2021
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 30, 2021

This is available in https://github.com/microsoft/vscode-cpptools/releases/tag/1.8.0-insiders
via the C_Cpp.references.maxCachedProcesses setting (it currently default to 0, i.e. opt-in).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature: Find All References Find All References, Peek References, Rename Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

4 participants