Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile_commands.json support doesn't understand -iquote #2088

Closed
nelhage opened this issue Jun 4, 2018 · 1 comment
Closed

compile_commands.json support doesn't understand -iquote #2088

nelhage opened this issue Jun 4, 2018 · 1 comment
Assignees
Labels
bug Feature: Compile Commands fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@nelhage
Copy link

nelhage commented Jun 4, 2018

The compile_commands.json support doesn't seem to extract include paths from -iquote arguments to the compiler.

You can reproduce by checking out https://github.com/nelhage/vscode_bazel_cxx and opening foo.cc; The foo.h include won't be found. If you edit compile_commands.json to use -isystem or -I instead, it will work.

(This isn't relevant to the bug since I was able to minimize to the above, but I'm using bazel and https://github.com/grailbio/bazel-compilation-database to generate my compile_commands, which is where I'm getting command files containing -iquote)

@bobbrow bobbrow added this to the On Deck milestone Jul 23, 2018
@sean-mcmanus sean-mcmanus modified the milestones: On Deck (old), On Deck Aug 29, 2018
@sean-mcmanus sean-mcmanus modified the milestones: On Deck, July 2019 Jun 21, 2019
@sean-mcmanus sean-mcmanus modified the milestones: August 2019, July 2019 Jul 10, 2019
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jul 10, 2019
@sean-mcmanus sean-mcmanus modified the milestones: July 2019, August 2019 Jul 16, 2019
@sean-mcmanus
Copy link
Contributor

Should be fixed with 0.25.0-insiders: https://github.com/microsoft/vscode-cpptools/releases/tag/0.25.0-insiders

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Compile Commands fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

4 participants