Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cancellation for References/Rename/Call Hierarchy #10998

Closed
michelleangela opened this issue May 23, 2023 · 1 comment · Fixed by #11056
Closed

Fix Cancellation for References/Rename/Call Hierarchy #10998

michelleangela opened this issue May 23, 2023 · 1 comment · Fixed by #11056
Assignees
@michelleangela
Labels
bug Feature: Call Hierarchy Feature: Find All References Find All References, Peek References, Rename Feature: Rename Language Service reliability
Milestone
1.16.1

Comments

@michelleangela
Copy link
Contributor

If a "references/rename/call hierarchy incoming calls" request is done and canceled, it may cause an incomplete response to the VS Code and result in the UI to look like the request is still in progress.

Re-work how cancelation or interruption of these requests are done and handled.
@michelleangela michelleangela added this to the 1.16.1 milestone May 23, 2023
@michelleangela michelleangela self-assigned this May 23, 2023
@michelleangela michelleangela linked a pull request Jun 7, 2023 that will close this issue
Fix references cancellation and preview #11056
Merged
@michelleangela
Copy link
Contributor Author

Fixed in pre-release 1.16.1 https://github.com/microsoft/vscode-cpptools/releases/tag/v1.16.1.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michelleangela michelleangela

Labels
bug Feature: Call Hierarchy Feature: Find All References Find All References, Peek References, Rename Feature: Rename Language Service reliability
Projects
None yet
Milestone
1.16.1
Development

Successfully merging a pull request may close this issue.

Fix references cancellation and preview microsoft/vscode-cpptools
1 participant
@michelleangela