Add file path to details of a call hierarchy result

[michelleangela]

Worked great when I used it before 👌 Only one detail on my wishlist which is to easily view which file the call resides in without clicking.

Originally posted by @csholmq in #16 (comment)

[csholmq]

When having multiple definitions it's easy to get confused which is which.

Perhaps something similar to how the search view works.

[michelleangela]

For what structure is shown in the results panel, this is actually managed by VS Code. For this change request, an issue will need to filed at https://github.com/Microsoft/vscode to change the UI panel.

What the extension can edit is the details properties of each function shown in the call tree. Currently the details display the containing name, such as namespace, of a function. The file path or name can be included in the details properties to provide more info about the function.

[csholmq]

File path would be nice but would be obscured for longer function names. Perhaps the hover could be utilized here and the function definition (which the hover seem to currently display) could be what's listed in the UI?

[sean-mcmanus]

Our extension doesn't have control over what is shown in the hover UI, but if the file path were added to the details then it would appear in the hover. We could also probably add the line and column info too.

[michelleangela]

Just to clarify, the details properties of a call hierarchy item is the info used for hover, that is hover does not provide additional info than what's already shown on the right side of the call hierarchy item. The tool tip is useful in allowing full visibility of text that's cut off when the window width is small. Here is an example:

Adding @AlexandraKemperMS for input.

[sean-mcmanus]

Yeah, that seems good to me, but I'm not sure what punctuation is ideal to separate the namespace/class from the file.

[michelleangela]

Suggested text format to display:

myFunction() - myNamespace - testFile.cpp (C:\myfolder\project)

This way, users can see the file name first.

[sean-mcmanus]

@michelleangela Yeah, sounds good to me.

[AlexandraKemperMS]

@michelleangela wouldn't we want to only show the file name in this case? Or show:

testFile.cpp (C:\myfolder\project)- myNamespace

so that the filename is first and namespace is second?

[sean-mcmanus]

@AlexandraKemperMS I think the namespace should go first, since it's more important than the file info.

[AlexandraKemperMS]

@sean-mcmanus I chatted with michelle, yes, namespace first is the way to go. Michelle's original suggestion is fine to me.

[michelleangela]

Fixed in pre-release 1.16.1 https://github.com/microsoft/vscode-cpptools/releases/tag/v1.16.1.

[michelleangela]

Fix is now available in release version 1.16.2.