Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation declaration/definition that targets a new file (or an empty one) has 2 extra newlines if clang-format isn't used #10164

Open
sean-mcmanus opened this issue Nov 17, 2022 · 1 comment
Labels
bug Feature: Create Declaration or Definition insiders Currently only repros with our latest Insiders release. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Nov 17, 2022

In test.h, do Create Declaration/Definition on

void func();

with an empty test.cpp.

Bug: The result has 2 extra newlines:

#include "test.h"



void func()
{
}

It's possible the root cause issue might result in other bugs, not sure though.

@sean-mcmanus sean-mcmanus added bug Language Service insiders Currently only repros with our latest Insiders release. Works in VS So we'd need to fix it for VS Code to reach parity. Feature: Create Declaration or Definition labels Nov 17, 2022
@sean-mcmanus sean-mcmanus self-assigned this Nov 17, 2022
@sean-mcmanus sean-mcmanus changed the title Creation declaration/definition that targets a new file (or an empty one) has 2 extra newlines Creation declaration/definition that targets a new file (or an empty one) has 2 extra newlines if clang-format isn't used Nov 29, 2022
@sean-mcmanus sean-mcmanus removed their assignment Nov 29, 2022
@sean-mcmanus
Copy link
Contributor Author

This got fixed in 1.13.5 (pre-release, release candidate): https://github.com/microsoft/vscode-cpptools/releases/tag/v1.13.5, but only if clang-format is used....I've updated the title to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Create Declaration or Definition insiders Currently only repros with our latest Insiders release. Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Development

No branches or pull requests

2 participants