Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide (default) configurations for sources not listed in CMakeLists.txt, based on file type #2530

Open
Colengms opened this issue May 4, 2022 · 0 comments
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: cpptools integration
Milestone

Comments

@Colengms
Copy link
Contributor

Colengms commented May 4, 2022

Brief Issue Summary

Currently, if the C/C++ extension doesn't receive a custom configuration from CMake Tools for a file, it will opportunistically fall back to using the compilerPath and compilerArgs provided with the custom browse configuration (a WorkspaceBrowseConfiguration). Unfortunately, the WorkspaceBrowseConfiguration might apply only to C++ files and not C files, or vice versa, as it contains only a single compilerPath and compilerArgs.

Perhaps CMake Tools could provide appropriate default configurations for files not included in any CMakeLists.txt? If CMake Tools has sufficient information to provide the default compilerPath and compilerArgs (as it's already is for the WorkspaceBrowseConfiguration), but based on a type of file, it could provide that as a configuration for that type of file.

That might let us to remove the current fallback logic, which is currently hindered by the existence of only a single compilerPath and compilerArgs. More information on that can be found here:

microsoft/vscode-cpptools-api#42
microsoft/vscode-cpptools#9266

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

@elahehrashedi elahehrashedi added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: cpptools integration labels May 24, 2022
@elahehrashedi elahehrashedi added this to the On Deck milestone May 24, 2022
@github-project-automation github-project-automation bot moved this to Triage Needed in CMake Tools Nov 29, 2023
@gcampbell-msft gcampbell-msft moved this from Triage Needed to Pending Prioritization in CMake Tools Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: cpptools integration
Projects
Status: Pending Prioritization
Development

No branches or pull requests

2 participants