Duplicate compiler flags should not be removed #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
changed the title
andreeis
approved these changes
Oct 21, 2020
bobbrow
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like CMake Tools is removing duplicate compiler flags from the browse config. Compiler flags are contextual, so none should be removed.
For example, there are various compiler args that themselves receive the next arg. (i.e.
-include,-x,-Xclang,-Xlinker). In my case, multiple-Xclanguses were generated by CMake.-Xclang -gcodeview -Xclang --dependent-lib=msvcrtd. After one of those-Xclang's was removed, cpptools attempted to use the browse config to probeclang.exewith-Xclang -gcodeview --dependent-lib=msvcrtd, resulting in an error that--dependent-lib=msvcrtdwas not recognized (as it's only valid after a-Xclang)This appears to only be a problem with the browse config. Individual custom configs appear to include duplicates.