-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oatpp-swagger] Feature/oatpp swagger 1.3.0 latest #42349
base: master
Are you sure you want to change the base?
[oatpp-swagger] Feature/oatpp swagger 1.3.0 latest #42349
Conversation
@microsoft-github-policy-service agree company="Alfred Kärcher SE & Co. KG" |
1 similar comment
@microsoft-github-policy-service agree company="Alfred Kärcher SE & Co. KG" |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "oatpp-swagger", | |||
"version": "1.3.0", | |||
"version": "1.3.0-latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, 1.3.0-latest
is older than 1.3.0
, so this will not have the sort order you want: https://learn.microsoft.com/vcpkg/users/versioning#version-semver
I filed oatpp/oatpp-swagger#95 against upstream to ask them to reconsider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not like the sketchy version either, it also made it necessary to stip the suffix off the version in the port cmake file to fit the extracted file name... so this is clearly would be cleaner 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update, I closed the swagger issue and opened against the main repo instead, which has the same problem: oatpp/oatpp#988
This adds the version oatpp-swagger
1.3.0-latest
since1.4.0
is still not ready, and this already brings an important feature, you can set the BASE_URL for the auto generated swagger routes../vcpkg x-add-version --all
and committing the result.