Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arpack-ng] Workaround "outdated dynamic CRT" #29935

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

FabienPean
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Fix recently added port based on comment #29248 (comment)

warning: Detected outdated dynamic CRT in the following files:
error: Found 1 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile: C:\a\1\s\ports\arpack-ng\portfile.cmake

Occurred in lapack-reference, see #29664 (comment) from changes in PR #29664 merged some days before #29248.

This PR applies a similar fix as e1d748c

@LilyWangLL LilyWangLL self-assigned this Mar 1, 2023
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Mar 1, 2023
@JackBoosY
Copy link
Contributor

Do you know why this port links to v120 toolset? Is this related to gFortran?

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a workaround.

@JackBoosY
Copy link
Contributor

ping @JavierMatosD, this is a baseline issue and it blocks many PRs.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 1, 2023
@FabienPean
Copy link
Contributor Author

Do you know why this port links to v120 toolset? Is this related to gFortran?

My guess is that it must be related to msys2 or gfortran, but I'm just mimicking the solution. @BillyONeal might know more about it.

@JavierMatosD JavierMatosD merged commit f1cebbc into microsoft:master Mar 1, 2023
@FabienPean FabienPean deleted the port/arpack-fix branch March 1, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants