Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[many ports]switch to vcpkg-cmake / vckg-cmake-config part 1 #29880

Merged
merged 16 commits into from
Mar 6, 2023
Merged

[many ports]switch to vcpkg-cmake / vckg-cmake-config part 1 #29880

merged 16 commits into from
Mar 6, 2023

Conversation

JackBoosY
Copy link
Contributor

  • Switch vcpkg_fixup_cmake_targets to vcpkg_cmake_config_fixup
  • Switch vcpkg_*_cmake to vcpkg_cmake_*
  • Add double quotes to the absolute paths.

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Feb 27, 2023 •
edited
Loading

There may have 500+ files so I have to split them into 5 PRs.

@JackBoosY JackBoosY mentioned this pull request Feb 27, 2023
Merged
@jimwang118 jimwang118 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Feb 27, 2023
@autoantwort
Copy link
Contributor

Have you used a script for it like in #26981?

@JackBoosY
Copy link
Contributor Author

Have you used a script for it like in #26981?

No, completely manual.

@JackBoosY
Copy link
Contributor Author

@autoantwort BTW, you should keep the number of modified files in your PR to a relatively small number.

@JackBoosY JackBoosY mentioned this pull request Feb 28, 2023
Open
Merge branch 'dev/jack/cleanup_vcpkg_fixup_cmake_targets' of github.c…
d4d09d3 
…om:JackBoosY/vcpkg; branch 'master' of https://github.com/microsoft/vcpkg into dev/jack/cleanup_vcpkg_fixup_cmake_targets
@JackBoosY
Copy link
Contributor Author

arpack-ng regression is a baseline issue.

@JackBoosY
Copy link
Contributor Author

Depends on #29935

@JackBoosY
Copy link
Contributor Author

@jimwang118 request review.

jimwang118
jimwang118 requested changes Mar 2, 2023
View reviewed changes
ports/ade/portfile.cmake Show resolved Hide resolved
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Mar 3, 2023
@dan-shaw dan-shaw merged commit a6cb729 into microsoft:master Mar 6, 2023
@JackBoosY JackBoosY deleted the dev/jack/cleanup_vcpkg_fixup_cmake_targets branch March 7, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimwang118 jimwang118 jimwang118 approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @autoantwort @jimwang118 @dan-shaw