-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pango] build failure on macOS #20367
Comments
Hi @autoantwort Thanks for posting this issue.
|
Yeah cairo is a dependency of pango, so it is installed.
This is done in the portfile.cmake in vcpkg master already |
But interestingly I now get a different error when I try to install pango: vcpkg/buildtrees/pango/package-x64-osx-dbg-out.log
|
Do you use xcode 12 on your machine?
Seems like this is a known issue in xcode12. |
Yes I used xcode 12, I now use xcode 13 but get the same error |
@autoantwort Thanks for posting this issue. |
Now already the dependency pixman failed |
@autoantwort Could you help test PR #22502 is useful for you? Because I can't reproduce this issue locally. |
I can't because the dependency pixman already does not build, but I think this will solve the issue. There are often problems on mac that c/c++11 is required but not enabled. |
It looks like I'm running into this issue as well when building on Github Actions using the
|
@Pentarctagon can you test if #22502 fixes your error? |
It does not. |
To add to that, the build errors reported are the exact same, including the ones about being "invalid in C99" even with building vcpkg like:
so it looks like the change in #22502 did not end up getting applied to the pango build. |
@Pentarctagon Thanks for your testing. Could you change |
No change from the previous attempt. |
Is this error still exist? |
That error still exists. The log is at https://github.com/Pentarctagon/wesnoth/runs/4799473865. The errors specifically are:
Since this is in a CI environment, the replacement was done with sed:
The contents of the portfile before and after the replacement via sed can be seen in the "Build vcpkg" section. |
Some further testing has the builds give the same "declaration of function is invalid in C99" with the current version of pango as well as the previous two (as listed at https://vcpkg.info/port/pango), though the errors aren't exactly the same. Earlier versions don't build since they refer to an ftp server that doesn't resolve anymore. |
This looks like the header file for fontconfig is not included. @Pentarctagon Could you test PR#22502 again? Thanks very much. |
The build errors reported remain the same. |
Also as a side note, pango does build successfully on Windows and has for some time. So this is macOS-specific. |
Sorry I have no idea why still failed. Could you provide your environment information and error log to upstream: https://gitlab.gnome.org/GNOME/pango/-/issues/657, you can comment there, maybe the manager of |
Is there a way to have vcpkg add in a build flag? The |
You can set VCPKG_CXX_FLAGS in your triplet |
Based on the output from that, the issue is that on the Github Actions CI, it's instead using
which is too old. |
Is there a workaround to get it to ignore the Mono header location in the mean time? I tried with |
What did you try exactly? |
First I tried the path I tried adding those to the triplet file with: and directly on the command line with: |
It looks like for now I can actually just uninstall Mono. |
After uninstall Mono, could you can install pango succeed? |
I think the underlying issue with Mono Frameworks on macOS was fixed three days ago with merging #23202. |
Ping @Pentarctagon for response, does this issue still exist? |
The issue still exists. If I have it stop uninstalling Mono, the vcpkg pango build fails. |
Now it fails with: |
It looks like this error is related with Github Actions CI, not vcpkg. I think this issue can be closed, if someone has new idea, please reopen this issue. |
Host Environment
Failure logs
pango/package-x64-osx-dbg-out.log
The text was updated successfully, but these errors were encountered: