Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[protobuf-c] Feature test relies on wrong dependency #11519

Closed
JackBoosY opened this issue May 22, 2020 · 4 comments · Fixed by #11609
Closed

[protobuf-c] Feature test relies on wrong dependency #11519

JackBoosY opened this issue May 22, 2020 · 4 comments · Fixed by #11609
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@JackBoosY
Copy link
Contributor

Describe the bug
When a certain port has multiple features and there is a dependency relationship between feature and feature, the feature that installs the port's dependency and other features will generate an error:

Package *** does not have a *** feature.

Example: protobuf-c has feature tools and test, and feature test depend on tools.

Environment

  • OS: [e.g. Windows/Linux etc...] All triplets
  • Compiler: revision

To Reproduce
Steps to reproduce the behavior:

  1. ./vcpkg install protobuf-c[test]
  2. See error
    Repro code when

Expected behavior
Port should be built succesfully as expected.

Failure logs
N/A

Additional context
N/A

@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label May 22, 2020
@JackBoosY JackBoosY changed the title [vcpkg] Error when constructing a port with certain feature [vcpkg] Error when building a port with certain feature May 22, 2020
@JackBoosY
Copy link
Contributor Author

JackBoosY commented May 22, 2020

auto maybe_paragraph = clust.m_scfl.source_control_file->find_feature(spec.feature());

It looks like vcpkg found the wrong port(protobuf) and feature(tools) matching value here.

feature_paragraphs seems wrong.

@Neumann-A
Copy link
Contributor

try changing:
protobuf[tools]
to
protobuf[core,tools]

@JackBoosY
Copy link
Contributor Author

@Neumann-A Not working.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support and removed category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) labels May 27, 2020
@JackBoosY JackBoosY changed the title [vcpkg] Error when building a port with certain feature [protobuf-c] Feature test relies on wrong dependency May 27, 2020
@JackBoosY
Copy link
Contributor Author

Well... I noticed the feature test dependency is wrong now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants