Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: Move instead of copy and use XMLWriter for DGML #1159

Merged
merged 18 commits into from
Aug 18, 2023
Merged

Cleanup: Move instead of copy and use XMLWriter for DGML #1159

merged 18 commits into from
Aug 18, 2023

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Aug 15, 2023 •
edited
Loading

  • BinaryParagraph(Paragraph) --> BinaryParagraph(Paragraph&&)
  • Add missing &
  • Use std::move
  • Initialize string instead of default-initialize + append

BillyONeal
BillyONeal requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly OK but I think there are 1 or 2 mistakes.
There are others that I think are correct but of which I am not in favor for maintainability reasons; maybe other contributors have different opinions on them.

src/vcpkg/commands.cache.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.check-support.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.ci-verify-versions.cpp Outdated Show resolved Hide resolved
src/vcpkg/paragraphs.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.create.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.dependinfo.cpp Outdated Show resolved Hide resolved
src/vcpkg/commands.dependinfo.cpp Outdated Show resolved Hide resolved
@BillyONeal BillyONeal changed the title Cleanup: Move instead of copy Cleanup: Move instead of copy and use XMLWriter for DGML Aug 18, 2023
@BillyONeal BillyONeal merged commit 95d864d into microsoft:main Aug 18, 2023
5 checks passed
@BillyONeal
Copy link
Member

Thanks for your contribution!

@Thomas1664 Thomas1664 deleted the cleanup-3 branch August 18, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas1664 @BillyONeal